Add ability to close editor and retrieve document without opening the last one #5080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhukovs
added
bug
|
During the resolving this problem another issue was created: #5079 |
azatsarynnyy
reviewed
May 6, 2019
| @@ -248,6 +248,13 @@ export class DocumentsExtImpl implements DocumentsExt { | |||
| }; | |||
| } | |||
| await this.proxy.$tryOpenDocument(uri, documentOptions); | |||
|
|
|||
| if (!options) { | |||
There was a problem hiding this comment.
Maybe it worth mentioning in the method's doc that omitting the options parameter actually means opening a document without showing it on UI? To make it a bit clearer...
And adding the link here to the related issue might help someone quicker understand why it has been implemented in such way and this is actually a temporary fix.
There was a problem hiding this comment.
Added comment with dependent issue and jsdoc
azatsarynnyy
approved these changes
May 6, 2019
|
Related issue: eclipse-che/che#13037 |
… last one Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes proposal adds small ability not to open editor if text document show options is undefined. This need to retrieve document object without opening the last one in persistence editor. This how vs code does in default behavior. This method, according to default vs code behavior should not open editor, but return document object. Sample use case, is just getting document content and open it in web view. Without this fix we can get two opened editors. To avoid huge refactoring in plugin's documents and editors related code, there was decided to add simple checks if text document show options is undefined, then we don't keep opened editor.
Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com