Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid call of unsupported function on Proxy #5094

Merged
merged 1 commit into from
May 8, 2019
Merged

Conversation

spoenemann
Copy link
Contributor

Fixes #5093. Extracted KeyValidator interface to be able to detect whether that service is supported.

Extracted KeyValidator interface to be able to detect whether that service is supported.

Signed-off-by: Miro Spönemann <miro.spoenemann@typefox.io>
@kittaakos
Copy link
Contributor

I am trying this now...

@kittaakos kittaakos self-requested a review May 8, 2019 10:22
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried it with both the electron and the browser examples: I do not see the Unhandled method validateKeyCode error anymore. 👍

Thank you for the quick fix!

@spoenemann spoenemann merged commit 879de31 into master May 8, 2019
@spoenemann spoenemann deleted the msp_issue5093 branch May 8, 2019 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[electron] Unhandled method validateKeyCode error in a bundled electron application
2 participants