-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress extension #5176
Progress extension #5176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I tested it out and it seems like the only thing that isn't working is when you focus something else the progress monitor still stays open.
packages/progress-monitor/src/browser/progress-monitor-contribution.ts
Outdated
Show resolved
Hide resolved
packages/progress-monitor/src/browser/progress-monitor-status-bar-item.ts
Outdated
Show resolved
Hide resolved
packages/progress-monitor/src/browser/progress-monitor-status-bar-item.ts
Outdated
Show resolved
Hide resolved
packages/progress-monitor/src/browser/progress-monitor-widget.ts
Outdated
Show resolved
Hide resolved
@JPinkney Several classes were added accidentally from your different commit. I have removed all that was unnecessary. Please, have a look. |
@olexii4 It looks like the progress monitor flickers if the progress reports are coming in really fast (Tested using Che), other then that everything is working as expected. |
@JPinkney I have updated it (fix the progress monitor flickers). |
@akosyakov @AlexTugarev Could you review this PR? |
Just tried it with 'git clone' - video |
'Looking into this today. |
@JPinkney Please, add your "Signed-off-by footer" |
Co-authored-by: Oleksii Orel <oorel@redhat.com> Signed-off-by: Josh Pinkney <joshpinkney@gmail.com> Signed-off-by: Oleksii Orel <oorel@redhat.com>
Thank you for your help in improving progress reporting in Theia. This is certainly something we need. I was wondering how this relates to the existing support for progress reporting in the I do not see any reason not to stick with the existing API. I can see there may be advantages in combining This PR is regressing on functionality by not including a 'cancel' button in the progress, as that can be added to the current drop-down progress. However as existing progress reporters would not automatically switch to your progress dialog, that is ok. My main concern is that we would now have two progress reporting systems, with some packages hooked up to one and some packages hooked up to another. Extenders currently will typically rebind MessageClient and delegate |
As a continuation of the PR, with the preservation of the authorship of an origin commit.
Just tried it with 'git clone' - video