Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] do not re-open an already currently opened workspace #5632

Merged
merged 1 commit into from
Jul 4, 2019

Commits on Jul 3, 2019

  1. Do not re-open an already currently opened workspace

    Fixes #5630
    
    - fixes an issue that allows users to open a workspace
    that is currently opened. If the user had the preference
    `"workspace.preserveWindow"` set to `false` it would open
    an identical workspace in a new tab, and if it was set to
    `true` it would reload the workspace. Instead, an additional
    check is performed to determine if the current workspace and
    the new destination are equal, and if they are a NOOP is
    instead performed by returning `undefined`.
    - fixes issue present in `OPEN` and `OPEN_WORKSPACE` for both
    the browser and electron based applications.
    
    Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
    vince-fugnitto committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    511fbab View commit details
    Browse the repository at this point in the history