Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusted the plug-in related logging. #5637

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Adjusted the plug-in related logging. #5637

merged 1 commit into from
Jul 4, 2019

Conversation

kittaakos
Copy link
Contributor

  • Got rid of the empty lines between the log entries.
  • Log the plug-in name and version when initializing.

From here: #5622 (comment)

Signed-off-by: Akos Kitta kittaakos@typefox.io

Before:

root INFO Theia app listening on http://localhost:3000.
root INFO unzipping the plugin ProxyPluginDeployerEntry {
  deployer:
   PluginVsCodeFileHandler {
     unpackedFolder:
      '/private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked' },
  delegate:
   PluginDeployerEntryImpl {
     originId: 'local-dir:../../plugins',
     pluginId: 'command-activation-event-0.0.1.vsix',
     map: Map {},
     changes: [],
     acceptedTypes: [],
     currentPath:
      '/Users/akos.kitta/git/theia/plugins/command-activation-event-0.0.1.vsix',
     initPath:
      '/Users/akos.kitta/git/theia/plugins/command-activation-event-0.0.1.vsix',
     resolved: true,
     resolvedByName: 'LocalDirectoryPluginDeployerResolver' },
  deployerName: 'PluginVsCodeFileHandler' }
root INFO unzipping the plugin ProxyPluginDeployerEntry {
  deployer:
   PluginVsCodeFileHandler {
     unpackedFolder:
      '/private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked' },
  delegate:
   PluginDeployerEntryImpl {
     originId: 'local-dir:../../plugins',
     pluginId: 'lang-activation-event-0.0.1.vsix',
     map: Map {},
     changes: [],
     acceptedTypes: [],
     currentPath:
      '/Users/akos.kitta/git/theia/plugins/lang-activation-event-0.0.1.vsix',
     initPath:
      '/Users/akos.kitta/git/theia/plugins/lang-activation-event-0.0.1.vsix',
     resolved: true,
     resolvedByName: 'LocalDirectoryPluginDeployerResolver' },
  deployerName: 'PluginVsCodeFileHandler' }
root INFO unzipping the plugin ProxyPluginDeployerEntry {
  deployer:
   PluginVsCodeFileHandler {
     unpackedFolder:
      '/private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked' },
  delegate:
   PluginDeployerEntryImpl {
     originId: 'local-dir:../../plugins',
     pluginId: 'ms-vscode.Go-0.11.1.vsix',
     map: Map {},
     changes: [],
     acceptedTypes: [],
     currentPath:
      '/Users/akos.kitta/git/theia/plugins/ms-vscode.Go-0.11.1.vsix',
     initPath:
      '/Users/akos.kitta/git/theia/plugins/ms-vscode.Go-0.11.1.vsix',
     resolved: true,
     resolvedByName: 'LocalDirectoryPluginDeployerResolver' },
  deployerName: 'PluginVsCodeFileHandler' }
root INFO PluginTheiaDirectoryHandler: accepting plugin with path /private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked/command-activation-event-0.0.1.vsix
root INFO Resolved "command-activation-event-0.0.1.vsix" to a VS Code extension "command-activation-event@0.0.1" with engines: { vscode: '^1.35.0' }
root INFO PluginTheiaDirectoryHandler: accepting plugin with path /private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked/lang-activation-event-0.0.1.vsix
root INFO Resolved "lang-activation-event-0.0.1.vsix" to a VS Code extension "lang-activation-event@0.0.1" with engines: { vscode: '^1.35.0' }
root INFO PluginTheiaDirectoryHandler: accepting plugin with path /private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked/ms-vscode.Go-0.11.1.vsix
root INFO Resolved "ms-vscode.Go-0.11.1.vsix" to a VS Code extension "Go@0.11.1" with engines: { vscode: '^1.25.0' }
root INFO Deploying backend plugin "command-activation-event@0.0.1" from "/private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked/command-activation-event-0.0.1.vsix/extension/out/extension.js"
root INFO Deploying backend plugin "lang-activation-event@0.0.1" from "/private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked/lang-activation-event-0.0.1.vsix/extension/out/extension.js"
root INFO Deploying backend plugin "Go@0.11.1" from "/private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked/ms-vscode.Go-0.11.1.vsix/extension/out/src/goMain"
root WARN LanguagesFrontendContribution.onStart is slow, took: 132.11499998578802 ms
root INFO Using Git [2.20.1] from the PATH. (/usr/local/bin/git)
root INFO [nsfw-watcher: 64954] Started watching: /Users/akos.kitta/.theia
root INFO [nsfw-watcher: 64954] Started watching: /Users/akos.kitta/Desktop/vscode
root INFO [nsfw-watcher: 64954] Started watching: /Users/akos.kitta/Desktop/vscode
root WARN EditorNavigationContribution.onStart is slow, took: 1096.8500000308268 ms
root INFO [hosted-plugin: 64959] PLUGIN_HOST(64959) starting instance

root INFO Checking whether '--no-optional-locks' can be used with the current Git executable. Minimum required version is '2.15.0'.
root INFO '--no-optional-locks' is a valid Git option for the current Git version: '2.20.1'.
root INFO Config file tasks.json does not exist under file:///Users/akos.kitta/Desktop/vscode
root INFO [nsfw-watcher: 64954] Started watching: /Users/akos.kitta/Desktop/vscode/.vscode/launch.json
root INFO Started watching the git repository: file:///Users/akos.kitta/Desktop/vscode
root INFO [nsfw-watcher: 64954] Started watching: /Users/akos.kitta/Desktop/vscode/.vscode/settings.json
root INFO [nsfw-watcher: 64954] Started watching: /Users/akos.kitta/Desktop/vscode/build/lib/git.ts
root INFO [hosted-plugin: 64959] PLUGIN_HOST(64959): PluginManagerExtImpl/init()

root INFO [hosted-plugin: 64959] PLUGIN_HOST(64959): initializing(/Users/akos.kitta/git/theia/packages/plugin-ext-vscode/lib/node/plugin-vscode-init.js)

root INFO [hosted-plugin: 64959] PLUGIN_HOST(64959): initializing(/Users/akos.kitta/git/theia/packages/plugin-ext-vscode/lib/node/plugin-vscode-init.js)

root INFO [hosted-plugin: 64959] PLUGIN_HOST(64959): initializing(/Users/akos.kitta/git/theia/packages/plugin-ext-vscode/lib/node/plugin-vscode-init.js)

root INFO [hosted-plugin: 64959] Debugger contribution has been registered: go

root INFO [hosted-plugin: 64959] PLUGIN_HOST(64959): PluginManagerExtImpl/loadPlugin(/private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked/command-activation-event-0.0.1.vsix/extension/out/extension.js)

root INFO [hosted-plugin: 64959] Congratulations, your extension "command-activation-event" is now active!

root INFO [hosted-plugin: 64959] PLUGIN_HOST(64959): PluginManagerExtImpl/loadPlugin(/private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked/lang-activation-event-0.0.1.vsix/extension/out/extension.js)

root INFO [hosted-plugin: 64959] PLUGIN_HOST(64959): PluginManagerExtImpl/loadPlugin(/private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked/ms-vscode.Go-0.11.1.vsix/extension/out/src/goMain)

root INFO [hosted-plugin: 64959] Debug configuration provider has been registered: go

After:

root INFO Theia app listening on http://localhost:3000.
root INFO unzipping the plugin ProxyPluginDeployerEntry {
  deployer:
   PluginVsCodeFileHandler {
     unpackedFolder:
      '/private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked' },
  delegate:
   PluginDeployerEntryImpl {
     originId: 'local-dir:../../plugins',
     pluginId: 'command-activation-event-0.0.1.vsix',
     map: Map {},
     changes: [],
     acceptedTypes: [],
     currentPath:
      '/Users/akos.kitta/git/theia/plugins/command-activation-event-0.0.1.vsix',
     initPath:
      '/Users/akos.kitta/git/theia/plugins/command-activation-event-0.0.1.vsix',
     resolved: true,
     resolvedByName: 'LocalDirectoryPluginDeployerResolver' },
  deployerName: 'PluginVsCodeFileHandler' }
root INFO unzipping the plugin ProxyPluginDeployerEntry {
  deployer:
   PluginVsCodeFileHandler {
     unpackedFolder:
      '/private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked' },
  delegate:
   PluginDeployerEntryImpl {
     originId: 'local-dir:../../plugins',
     pluginId: 'lang-activation-event-0.0.1.vsix',
     map: Map {},
     changes: [],
     acceptedTypes: [],
     currentPath:
      '/Users/akos.kitta/git/theia/plugins/lang-activation-event-0.0.1.vsix',
     initPath:
      '/Users/akos.kitta/git/theia/plugins/lang-activation-event-0.0.1.vsix',
     resolved: true,
     resolvedByName: 'LocalDirectoryPluginDeployerResolver' },
  deployerName: 'PluginVsCodeFileHandler' }
root INFO unzipping the plugin ProxyPluginDeployerEntry {
  deployer:
   PluginVsCodeFileHandler {
     unpackedFolder:
      '/private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked' },
  delegate:
   PluginDeployerEntryImpl {
     originId: 'local-dir:../../plugins',
     pluginId: 'ms-vscode.Go-0.11.1.vsix',
     map: Map {},
     changes: [],
     acceptedTypes: [],
     currentPath:
      '/Users/akos.kitta/git/theia/plugins/ms-vscode.Go-0.11.1.vsix',
     initPath:
      '/Users/akos.kitta/git/theia/plugins/ms-vscode.Go-0.11.1.vsix',
     resolved: true,
     resolvedByName: 'LocalDirectoryPluginDeployerResolver' },
  deployerName: 'PluginVsCodeFileHandler' }
root INFO PluginTheiaDirectoryHandler: accepting plugin with path /private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked/command-activation-event-0.0.1.vsix
root INFO Resolved "command-activation-event-0.0.1.vsix" to a VS Code extension "command-activation-event@0.0.1" with engines: { vscode: '^1.35.0' }
root INFO PluginTheiaDirectoryHandler: accepting plugin with path /private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked/lang-activation-event-0.0.1.vsix
root INFO Resolved "lang-activation-event-0.0.1.vsix" to a VS Code extension "lang-activation-event@0.0.1" with engines: { vscode: '^1.35.0' }
root INFO PluginTheiaDirectoryHandler: accepting plugin with path /private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked/ms-vscode.Go-0.11.1.vsix
root INFO Resolved "ms-vscode.Go-0.11.1.vsix" to a VS Code extension "Go@0.11.1" with engines: { vscode: '^1.25.0' }
root INFO Deploying backend plugin "command-activation-event@0.0.1" from "/private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked/command-activation-event-0.0.1.vsix/extension/out/extension.js"
root INFO Deploying backend plugin "lang-activation-event@0.0.1" from "/private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked/lang-activation-event-0.0.1.vsix/extension/out/extension.js"
root INFO Deploying backend plugin "Go@0.11.1" from "/private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked/ms-vscode.Go-0.11.1.vsix/extension/out/src/goMain"
root WARN LanguagesFrontendContribution.onStart is slow, took: 140.46999998390675 ms
root INFO Using Git [2.20.1] from the PATH. (/usr/local/bin/git)
root INFO [nsfw-watcher: 65090] Started watching: /Users/akos.kitta/.theia
root INFO [nsfw-watcher: 65090] Started watching: /Users/akos.kitta/Desktop/vscode
root INFO [nsfw-watcher: 65090] Started watching: /Users/akos.kitta/Desktop/vscode
root WARN EditorNavigationContribution.onStart is slow, took: 1016.5000000270084 ms
root INFO Checking whether '--no-optional-locks' can be used with the current Git executable. Minimum required version is '2.15.0'.
root INFO '--no-optional-locks' is a valid Git option for the current Git version: '2.20.1'.
root INFO [hosted-plugin: 65095] PLUGIN_HOST(65095) starting instance
root INFO Config file tasks.json does not exist under file:///Users/akos.kitta/Desktop/vscode
root INFO [nsfw-watcher: 65090] Started watching: /Users/akos.kitta/Desktop/vscode/.vscode/launch.json
root INFO Started watching the git repository: file:///Users/akos.kitta/Desktop/vscode
root INFO [nsfw-watcher: 65090] Started watching: /Users/akos.kitta/Desktop/vscode/.vscode/settings.json
root INFO [nsfw-watcher: 65090] Started watching: /Users/akos.kitta/Desktop/vscode/build/lib/git.ts
root INFO [hosted-plugin: 65095] PLUGIN_HOST(65095): PluginManagerExtImpl/init()
root INFO [hosted-plugin: 65095] PLUGIN_HOST(65095): initializing(command-activation-event@0.0.1 with /Users/akos.kitta/git/theia/packages/plugin-ext-vscode/lib/node/plugin-vscode-init.js)
root INFO [hosted-plugin: 65095] PLUGIN_HOST(65095): initializing(lang-activation-event@0.0.1 with /Users/akos.kitta/git/theia/packages/plugin-ext-vscode/lib/node/plugin-vscode-init.js)
root INFO [hosted-plugin: 65095] PLUGIN_HOST(65095): initializing(Go@0.11.1 with /Users/akos.kitta/git/theia/packages/plugin-ext-vscode/lib/node/plugin-vscode-init.js)
root INFO [hosted-plugin: 65095] Debugger contribution has been registered: go
root INFO [hosted-plugin: 65095] PLUGIN_HOST(65095): PluginManagerExtImpl/loadPlugin(/private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked/command-activation-event-0.0.1.vsix/extension/out/extension.js)
root INFO [hosted-plugin: 65095] Congratulations, your extension "command-activation-event" is now active!
root INFO [hosted-plugin: 65095] PLUGIN_HOST(65095): PluginManagerExtImpl/loadPlugin(/private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked/lang-activation-event-0.0.1.vsix/extension/out/extension.js)
root INFO [hosted-plugin: 65095] PLUGIN_HOST(65095): PluginManagerExtImpl/loadPlugin(/private/var/folders/k3/d2fkvv1j16v3_rz93k7f74180000gn/T/vscode-unpacked/ms-vscode.Go-0.11.1.vsix/extension/out/src/goMain)
root INFO [hosted-plugin: 65095] Debug configuration provider has been registered: go

Adjusted the plug-in related logging.
e93d1fc 
 - Got rid of the empty lines between the log entries.
 - Log the plug-in `name` and `version` when initializing.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos kittaakos requested a review from benoitf July 4, 2019 09:33
@kittaakos kittaakos requested a review from evidolob as a code owner July 4, 2019 09:33
benoitf
benoitf approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as described in description :-)

@benoitf
Copy link
Contributor

benoitf commented Jul 4, 2019

IMHO it's still too verbose but this is not the goal of this PR

@kittaakos kittaakos merged commit 20251ea into master Jul 4, 2019
@kittaakos kittaakos deleted the plugin-logging branch July 4, 2019 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@evidolob evidolob Awaiting requested review from evidolob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kittaakos @benoitf