Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[search-in-workspace] add the 'search.collapseResults' preference #5686

Merged
merged 1 commit into from
Jul 12, 2019

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Jul 10, 2019

Fixes #5685

Added the new preference to the search-in-workspace widget to
control the display of the tree when rendering results.

The values are the following:

  • auto: expand all nodes except those with over 10 matches
  • alwaysCollapse: always collapse all nodes
  • alwaysExpand: always expand all nodes

Aligned the setting with vscode, previously we used 20 results, but it's been updated to 10.


Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com

Fixes #5685

Added the new preference to the search-in-workspace widget to
control the display of the tree when rendering results.

The values are the following:
- `auto`: expand all nodes except those with over 10 matches
- `alwaysCollapse`: always collapse all nodes
- `alwaysExpand`: always expand all nodes

Aligned the setting with vscode, previously we used 20 results,
but it's been updated to 10.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves search in workspace issues related to the search-in-workspace labels Jul 10, 2019
@vince-fugnitto vince-fugnitto self-assigned this Jul 10, 2019
Copy link

@fangnx fangnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! I have tested search-in-workspace in all three modes and they worked as expected.

Copy link
Contributor

@elaihau elaihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in both single and multi root workspace. Thank you for the work !

@akosyakov akosyakov requested a review from jbicker July 11, 2019 09:32
@vince-fugnitto
Copy link
Member Author

The CQ has been approved.

@vince-fugnitto
Copy link
Member Author

@akosyakov should I wait for @jbicker to provide a review?

@jbicker
Copy link
Contributor

jbicker commented Jul 12, 2019

Hi, I will have a quick look into it. Wait a second...

Copy link
Contributor

@jbicker jbicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly! Thanks!

@vince-fugnitto
Copy link
Member Author

@jbicker I didn't mean to rush you or anything 🙈I just wanted to know if you wanted to take a look :)

@jbicker
Copy link
Contributor

jbicker commented Jul 12, 2019

No problem. It just suited my plans. ;-)

@vince-fugnitto vince-fugnitto merged commit f2681ee into master Jul 12, 2019
@vince-fugnitto vince-fugnitto deleted the vf/GH-5685 branch July 12, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves search in workspace issues related to the search-in-workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[search-in-workspace] add the 'search.collapseResults' preference
4 participants