-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[search-in-workspace] add the 'search.collapseResults' preference #5686
Conversation
Fixes #5685 Added the new preference to the search-in-workspace widget to control the display of the tree when rendering results. The values are the following: - `auto`: expand all nodes except those with over 10 matches - `alwaysCollapse`: always collapse all nodes - `alwaysExpand`: always expand all nodes Aligned the setting with vscode, previously we used 20 results, but it's been updated to 10. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change! I have tested search-in-workspace
in all three modes and they worked as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in both single and multi root workspace. Thank you for the work !
The CQ has been approved. |
@akosyakov should I wait for @jbicker to provide a review? |
Hi, I will have a quick look into it. Wait a second... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works perfectly! Thanks!
@jbicker I didn't mean to rush you or anything 🙈I just wanted to know if you wanted to take a look :) |
No problem. It just suited my plans. ;-) |
Fixes #5685
Added the new preference to the search-in-workspace widget to
control the display of the tree when rendering results.
The values are the following:
auto
: expand all nodes except those with over 10 matchesalwaysCollapse
: always collapse all nodesalwaysExpand
: always expand all nodesAligned the setting with vscode, previously we used 20 results, but it's been updated to 10.
Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com