Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[file-dialog] fix scaling issue for the file and save dialogs #5688

Merged
merged 1 commit into from
Jul 11, 2019

Commits on Jul 11, 2019

  1. Fix scaling issue for the file and save dialogs

    Fixes #1935
    
    - added the `theia-ResponsiveFileDialog` class so extenders
    can easily use the class to get the default styling of the
    `file-dialog` and its responsive media query.
    
    Our `file-dialog` and `save-dialog` have scaling issues
    when the screen's viewport is limited. Since our dialogs
    are not implemented using React (which would handle scaling much easier),
    the problem was addressed using css media queries. This means that when
    the view becomes limited at 700px, the size of the `file-tree` is
    reduced allowing the entire dialog to more easily visible and the
    actions buttons still accessible.
    
    Before, the buttons were not visible which meant the useability
    of the dialog was reduced.
    
    Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
    vince-fugnitto committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    a7fe72c View commit details
    Browse the repository at this point in the history