Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[keybindings] Aligned keybindings with VSCode" #5770

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Revert "[keybindings] Aligned keybindings with VSCode" #5770

merged 1 commit into from
Jul 23, 2019

Conversation

kittaakos
Copy link
Contributor

Reverts #5326

#5326 is causing a regression on Windows. See #5749.

@kittaakos
Copy link
Contributor Author

CC @JPinkney

@kittaakos kittaakos requested a review from akosyakov July 22, 2019 09:07
@akosyakov
Copy link
Member

@kittaakos ECA is missing

@tsmaeder we have to revert it for now unfortunately, since it breaks keybindings. I hope you find someone later to look into these issues. We would be glad to review a new PR.

@akosyakov akosyakov added the keybindings issues related to keybindings label Jul 22, 2019
@kittaakos
Copy link
Contributor Author

kittaakos commented Jul 22, 2019 •
edited
Loading

@kittaakos ECA is missing

I cannot do much with it. See: #5770 (comment)

@akosyakov
Copy link
Member

I see, you've already signed off a commit. Are you sure that your ECA is not expired? @marcdumais-work can we merge it like that?

@kittaakos
Copy link
Contributor Author

kittaakos commented Jul 22, 2019 •
edited
Loading

Are you sure that your ECA is not expired?

Yes, I am positive.

My private email address is not exposed via GH. Hence, GH substitutes my address with something else. In general, whenever I create a PR via the web UI, it happens all the time.

Screen Shot 2019-07-22 at 12 56 59

@marcdumais-work
Copy link
Contributor

My private email address is not exposed via GH. Hence, GH substitutes my address with something else. In general, whenever I create a PR via the web UI, it happens all the time.

Looks like the ECA checker is not smart enough to map this GH-generated email addr to your "real" one. I think you can fix this by fetching the branch on your computer, amending in the following way and force-pushing back here:

git commit --amend --author="Akos Kitta <kittaakos@typefox.io>"

Revert "Fixed #5303. Aligned keybindings with VSCode"
dd51244 
This reverts commit 1f9472e.

Reverts #5326.
Closes #5749.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
akosyakov
akosyakov approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittaakos please merge if build is green, thank you for taking care about it

@kittaakos kittaakos merged commit 5137616 into master Jul 23, 2019
@kittaakos kittaakos deleted the revert-5326-vscode-keys3 branch July 23, 2019 07:07
@akosyakov akosyakov mentioned this pull request Jul 24, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov approved these changes

@benoitf benoitf Awaiting requested review from benoitf

@evidolob evidolob Awaiting requested review from evidolob

Assignees
No one assigned
Labels
keybindings issues related to keybindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kittaakos @akosyakov @marcdumais-work