deps: upgrade+update #5955
Closed
deps: upgrade+update #5955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please wait with it till #5901 is merged. It will change our dependencies. |
akosyakov
reviewed
Aug 16, 2019
`yarn audit` reports 16k issues with our packages. This commit brings it down to zero. We should keep running `yarn upgrade` in the future, in order to develop against the same dependencies as our clients. Since `sinon` was bumped, some old behaviour seems to have changed. Fixed the parts of the tests where the failures occured. Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
paul-marechal
force-pushed
the
mp/yarn-audit
branch
from
d4d38b0 to
edba54a
Compare
|
@marechal-p It would be fine now to update yarn lock file. |
|
@akosyakov thanks for the reminder. I tried rebasing, but for some reason I got to a point where I would have a build error due to some typing, but in the IDE types would be correct (no error). I will see if I can get back to it later. |
|
Closing in favor of #6255 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Upgrade most of our dependencies, and bump some of them in order to bring
yarn auditfrom 16k issues down to 0.This is roughly equivalent to deleting
yarn.lockand generating a fresh one. To whomever concerned by this: Clients were never dependent on our lock file: they always pull the most recent versions based on their own version ranges and their own lock files.Most conflicts were typing issues, and some vulnerabilities required me to bump some dependencies.
The good thing is that thanks to this, we'll keep developing with up-to-date dependencies, and we can affirm that according to
yarn audit, the framework isn't distributed with widely-spread vulnerabilities.Fixes #5952
How to test
yarn auditshould report 0 issues.yarn buildandyarn testshould both complete successfully.@theia/example-*applications should still run.Review checklist
Reminder for reviewers