Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small adjustments in scm and search in workspace css #6116

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Conversation

jbicker
Copy link
Contributor

@jbicker jbicker commented Sep 5, 2019

What it does

Aligns header/input area of SCM and Search In Workspace Extensions.
Fixes #5751

How to test

Start theia and switch between the sidebars with SCM and Search In Workspace

Review checklist

Reminder for reviewers

@jbicker jbicker requested a review from kittaakos September 5, 2019 13:45
@kittaakos
Copy link
Contributor

Nice 👍 It is much better than it was.

The SIW input seems to have a greater height than the input in SCM.

screencast 2019-09-05 15-55-58

@akosyakov akosyakov added the scm issues related to the source control manager label Sep 5, 2019

Verified

This commit was signed with the committer’s verified signature.
renovate-bot Mend Renovate
Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
@jbicker
Copy link
Contributor Author

jbicker commented Sep 5, 2019

Adjusted the heights once more.

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks much better now! 👍

@vince-fugnitto vince-fugnitto changed the title Small adjustments in scm and searhc in workspace css Small adjustments in scm and search in workspace css Sep 5, 2019
@jbicker jbicker merged commit 34cb2d0 into master Sep 6, 2019
@jbicker jbicker deleted the GH-5751 branch September 6, 2019 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scm issues related to the source control manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement][ui/ux] Align the header and input in the SIW and SCM views
4 participants