Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin] withProgress should start task immediately #6123

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

AlexTugarev
Copy link
Contributor

@AlexTugarev AlexTugarev commented Sep 6, 2019

What it does

Fixes delayed task execution in withProgress. The resolution of the promise returned by the task may in some cases depend on the task being executed asap, e.g. the python extension expects that the task is running immediately in order to create a deferred promise, which if delayed breaks the removal of progress.

In case of python extension it led to the never ending Refreshing Python Interpreters progress.

Screen Shot 2019-09-06 at 09 14 29

How to test

  1. install vscode extension for python and open a .py file
  2. verify that Refreshing Python Interpreters will be hidden when done

2019-09-06 09 12 33

Review checklist

Reminder for reviewers

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
@akosyakov akosyakov added plug-in system issues related to the plug-in system progress issues related to the progress functionality labels Sep 6, 2019
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested that python extension does not live stale progress anymore

@AlexTugarev AlexTugarev merged commit 11fd485 into master Sep 6, 2019
@vince-fugnitto vince-fugnitto deleted the at/withProgress-fix branch September 29, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system progress issues related to the progress functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants