fix bug:The datas of Complete exists repeatedly #6130
Conversation
|
Please elaborate what is the root cause and how this PR supposed to fix it? |
OK |
Signed-off-by: xieyuanhu <xieyuanhuata@163.com>
akosyakov
added
the
🤔 needs more info
| } | ||
|
|
||
| private addNewAdapter(adapter: Adapter, selector?: theia.DocumentSelector, triggerCharacters?: string[]): number { | ||
| const callId = selector ? this.nextNewCallId(selector, triggerCharacters) : this.nextCallId(); |
There was a problem hiding this comment.
Please explain what is supposed to fix and how?
There was a problem hiding this comment.
I don't think there is a need to create multiple duplicate adapters for scenes with the same selector and triggerCharacters.
There was a problem hiding this comment.
2 different vscode extensions contribute different providers for the same selector and trigger characters?
There was a problem hiding this comment.
This situation is extreme but still exists, such as: vscode intellicode and redhat-java
There was a problem hiding this comment.
I don't understand an issue with that. Each provider should be handled independent and has own id.
There was a problem hiding this comment.
I think we need to do something specific for this particular scenes.
There was a problem hiding this comment.
If deduplication is done at the data level, there is bound to be loss in overall performance.
There was a problem hiding this comment.
@akosyakov
My solution is:
If the selector and the triggerCharacters are the same, then only one provider is provided.
There was a problem hiding this comment.
Of course, this problem also exists in vscode, I think this is a flaw in the design of vscode.
There was a problem hiding this comment.
I think you should file a bug against vscode intellicode and redhat-java, and ask whether they supposed to be used together. It does not seem like that to me.
Code wise changes don't look good, it will lead to issues in other cases.
|
Having multiple sources for language-related features like code completion is not a mistake, it's explicitly a feature of the VS Code API and LSP. For example, there is a language server providing completion for Apache Camel stuff inside Java files. |
@tsmaeder Could you provide a link to it? Could it be that our Monaco version does not support it well? @xieyuanhuata Could you try against #5901? |
|
@tsmaeder |
If you look, for example at "registerCompletionProvider" here, it mentions what to do when there are multiple providers registered for the same document selector. There are similar rules for other providers described in the document. |
|
Thank you for your contribution! Unfortunately, the pull-request is outdated with conflicts (>1 year old) and there has not been any recent activity. |
Signed-off-by: xieyuanhu xieyuanhuata@163.com
What it does
fix #6128 If the selectors and triggerCharacters of the two plugins are the same, then the datas of Complete will be duplicated.So,it is no need to generate two adapters for plugins with the same selector and triggerCharacters.
How to test
1、Install vscode plugins and the hello-plugin into theia，and then start theia;
redhat.java-0.46.0.vsix --- https://marketplace.visualstudio.com/items?itemName=redhat.java
vscjava.vscode-java-debug-0.20.0.vsix --- https://marketplace.visualstudio.com/items?itemName=vscjava.vscode-java-debug
vscjava.vscode-java-dependency-0.4.0.vsix -- https://marketplace.visualstudio.com/items?itemName=vscjava.vscode-java-dependency
vscjava.vscode-maven-0.17.0.vsix --- https://marketplace.visualstudio.com/items?itemName=vscjava.vscode-maven
vscode-java-test-0.18.2.vsix --- https://marketplace.visualstudio.com/items?itemName=vscjava.vscode-java-test
2、Open a java project，and insert a chart;
Review checklist
Reminder for reviewers