Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin] contribute.keybindings can be objects or arrays. #6243

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

svenefftinge
Copy link
Contributor

What it does

Aligns with VS Code which allows to use both single raw keybindings or arrays of them in package.json contributions.

How to test

Install an extension that doesn't wrap a single keybinding in an array, like e.g. https://github.com/Cmacu/gotoanything/blob/master/package.json#L65

Review checklist

Reminder for reviewers

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
@svenefftinge
Copy link
Contributor Author

Because it is the second time we had such an incompatibility, I also made the code more robust by wrapping the individual contributions in try-catch. So that a single issue doesn't leave the extension half initialized and we get a better error message.

@akosyakov akosyakov added the vscode issues related to VSCode compatibility label Sep 23, 2019
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good, tested that a keybinding as an object is registered

@svenefftinge svenefftinge merged commit a371f01 into master Sep 24, 2019
@svenefftinge svenefftinge deleted the se/plugin_contrib_keybindings branch September 24, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants