Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add content assist for input variables in tasks.json #6334

Merged
merged 1 commit into from
Oct 7, 2019
Merged

add content assist for input variables in tasks.json #6334

merged 1 commit into from
Oct 7, 2019

Conversation

elaihau
Copy link
Contributor

@elaihau elaihau commented Oct 7, 2019

  • content assist is added to help the users of tasks.json input variables.
  • changes made to VariableResolverService and CommonVariableContribution
    in support input variables for tasks #6331 are reverted.

Signed-off-by: Liang Huang liang.huang@ericsson.com

How to test

  • Open .theia/tasks.json, and enter input variables.
  • Check if the editor provides content assist.

Review checklist

add content assist for input variables in tasks.json
72eedd5 
- content assist is added to help the users of tasks.json input variables.
- changes made to VariableResolverService and CommonVariableContribution
in #6331 are reverted.

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
@elaihau elaihau requested a review from akosyakov October 7, 2019 01:55
@elaihau
Copy link
Contributor Author

elaihau commented Oct 7, 2019

I am also checking what I can do in ProcessTaskResolver, the client of VariableResolverService, to better inform users which variables are not defined.

@akosyakov akosyakov added the tasks issues related to the task system label Oct 7, 2019
@akosyakov
Copy link
Member

@elaihau I don’t think we need to change clients to handle undefined, but do #6333 (comment)

akosyakov
akosyakov reviewed Oct 7, 2019
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. I can test only later. @vince-fugnitto could you give It a go please?

vince-fugnitto
vince-fugnitto approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
It works well for me, I now get content assist when editing input variables in the tasks.json.

@akosyakov
Copy link
Member

please merge

@vince-fugnitto vince-fugnitto merged commit f73e224 into master Oct 7, 2019
@vince-fugnitto vince-fugnitto deleted the Liang/fix_task_input branch October 7, 2019 14:58
@vince-fugnitto
Copy link
Member

@elaihau I merged for you :)

@elaihau
Copy link
Contributor Author

elaihau commented Oct 7, 2019

Thank you Vincent!

@elaihau elaihau mentioned this pull request Oct 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

@akosyakov akosyakov akosyakov approved these changes

Assignees
No one assigned
Labels
tasks issues related to the task system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elaihau @akosyakov @vince-fugnitto