Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-6598: Exposed all handlers for a command. #6599

Merged
merged 1 commit into from
Nov 21, 2019
Merged

GH-6598: Exposed all handlers for a command. #6599

merged 1 commit into from
Nov 21, 2019

Conversation

kittaakos
Copy link
Contributor

Closes #6598.

Signed-off-by: Akos Kitta kittaakos@typefox.io

What it does

Exposed all handlers for a particular command via the new API.

How to test

Check the CI and the new tests.

Review checklist

Reminder for reviewers

Closes #6598.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me :)
I think we just need to wait for CI to complete.

Copy link
Contributor

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable. 👍

@akosyakov akosyakov added the core issues related to the core of the application label Nov 21, 2019
@kittaakos kittaakos merged commit 0860ab1 into master Nov 21, 2019
@kittaakos kittaakos deleted the GH-6598 branch November 21, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core issues related to the core of the application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[commands] As an extension developer I want to access all handlers for a command
4 participants