Fix 'terminal' extension typos #6692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes `@theia/terminal` extension typos. - renames `TerminalCopyOnSelectionHander` to `TerminalCopyOnSelectionHandler`. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/terminal-typos
branch
from
e2f6dba
to
f15c1b5
Compare
kittaakos
approved these changes
Dec 5, 2019
There was a problem hiding this comment.
Your changes look good to me, @vince-fugnitto! Thanks for taking care of it.
| if (state === 'granted') { | ||
| return true; | ||
| } | ||
| } catch (e) {} | ||
| } catch (e) { } |
There was a problem hiding this comment.
[minor]: you could omit e.
There was a problem hiding this comment.
Thanks! I tried your suggestion and it looks like it complains:
I'll keep it as is for the moment.
There was a problem hiding this comment.
No worries, for the next time; the syntax is try { } catch { } finally { } or try { } catch (e) { } finally { }
AndrienkoAleksandr
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
@theia/terminalextension typos.TerminalCopyOnSelectionHandertoTerminalCopyOnSelectionHandler.terminal-copy-on-selection-handler.ts.How to test
terminalextension)Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com