Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set the electron app name. #6726

Merged
merged 1 commit into from
Dec 9, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Explicitly set the electron app name.
To have better menu items on macOS.
("About", "Hide", and "Quit")

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Akos Kitta committed Dec 9, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 5e27f516ae64f24771701784b67604e6c673da3d
Original file line number Diff line number Diff line change
@@ -141,6 +141,10 @@ const Storage = require('electron-store');
const electronStore = new Storage();

app.on('ready', () => {
// Explicitly set the app name to have better menu items on macOS. ("About", "Hide", and "Quit")
// See: https://github.com/electron-userland/electron-builder/issues/2468
app.setName(applicationName);

const { screen } = electron;

// Remove the default electron menus, waiting for the application to set its own.