Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support presentation.reveal and presentation.focus in task config #6812

Closed
wants to merge 1 commit into from

Conversation

elaihau
Copy link
Contributor

@elaihau elaihau commented Jan 3, 2020

  • put focus on the terminal if presentation.reveal = "always",

  • do not activate the terminal if presentation.reveal = "never",

  • when presentation.reveal = "silent", activate the terminal only if errors are found from the task output by the parser

  • when users start a task that is already active, put focus on the
    terminal if presentation.focus = true, or presentation.reveal = "always"

Signed-off-by: Liang Huang lhuang4@ualberta.ca

How to test

  1. Open a workspace and add some tasks
  2. Try adding "presentation" into the task config, and see if getting any content assist.
  3. Verify the following scenarios:
    3.1 adding "presentation": { "reveal": "always", "focus": false } to task config shouldn't change the behavior of Theia
    3.2 having "presentation": { "reveal": "never", "focus": false } in task config should leave the terminal for the task not-focused
    3.3 adding "presentation": { "reveal": "never", "focus": false } in a long running task, start the long running task, and start it one more time - the terminal should not be activated throughout all steps
    3.4 adding "presentation": { "reveal": "never", "focus": true }, or "presentation": { "reveal": "always", "focus": false } in a long running task, and try the rest of 3.3 - the terminal should have the focus.
    3.5 adding "presentation": { "reveal": "silent", "focus": false } in a task, run the task, if the task has no problem matcher defined, or finishes without having errors (warnings and infos are not considered errors), the terminal should not get focus
    3.6 Replicate 3.5 with a task whose problem matcher finds errors from the task output - the terminal should get focus immediately after the first error is found.

Review checklist

@elaihau elaihau force-pushed the Liang/presentation_focus_reveal branch from c9b779a to a7c36a1 Compare January 3, 2020 00:45
- put focus on the terminal if presentation.reveal = "always",
- do not activate the terminal if presentation.reveal = "never",
- when presentation.reveal = "silent", activate the terminal only if errors are found from the task output by the parser

- when users start a task that is already active, put focus on the
terminal if presentation.focus = true, or presentation.reveal = "always"

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
@elaihau elaihau force-pushed the Liang/presentation_focus_reveal branch from a7c36a1 to 0c79bf0 Compare January 3, 2020 00:51
@elaihau elaihau closed this Jan 3, 2020
@elaihau elaihau deleted the Liang/presentation_focus_reveal branch January 3, 2020 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant