Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the debug console user input alignment #6958

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Adjust the debug console user input alignment #6958

merged 1 commit into from
Jan 27, 2020

Conversation

kaiyue0329
Copy link
Contributor

Fixes #5208

What it does

  • Adjusts the vertical alignment of the debug console input
  • Uses css variable to compute height of debug console input field

Review checklist

Reminder for reviewers

Fixes #5208

- Adjusts the vertical alignment of the debug console input
- Uses css variable to compute height of debug console input field

Signed-off-by: Kaiyue Pan <kaiyue.pan@ericsson.com>
@vince-fugnitto vince-fugnitto added console issues related to the console debug issues that related to debug functionality labels Jan 23, 2020
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks much better now and also makes use of css variables 👍

@akosyakov
Copy link
Member

@vince-fugnitto looks good now, please merge

@vince-fugnitto vince-fugnitto merged commit 8ff8bdc into eclipse-theia:master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console issues related to the console debug issues that related to debug functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[console] adjust alignment of debug console input
3 participants