fix #6976: XSS in New File dialog. #6977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit replaces call to innerHTML with a call to innerText to ensure user supplied text will not create elements in the DOM. An alternative to this approach would be to sanitize user input before adding it to the DOM. Signed-off-by: Casey Flynn <caseyflynn@google.com>
akosyakov
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes XSS sink in the New File dialog.
A side effect of this change is the error message displayed no longer displays the erroneous file name in bold.
How to test
Click File-> New File
Enter <style onload=alert(0)> in the text box
An alert should not be displayed on the page.
Review checklist
Reminder for reviewers
Signed-off-by: Casey Flynn caseyflynn@google.com