fix #6987 XSS vulnerability in browser sidebar #6988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change simply updates innerHtml to innerText to ensure user supplied content does not impact the dom. Signed-off-by: Casey Flynn <caseyflynn@google.com>
|
Can you guys please publish a security advisory on GitHub (see security tab) so that anybody using the vulnerable versions gets sent an email automatically? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
fixes #6987 XSS vulnerability in browser sidebar
Change simply updates innerHtml to innerText to ensure user supplied
content does not impact the dom.
How to test
Create a folder outside of Theia named "<style onload=alert(0)>"
1.a Example: mkdir <style\ onload=alert(0)>
In Theia click FIle -> Open Workspace
Select the directory named <style onload=alert(0)>
Open the file explorer
No alert should be displayed.
Review checklist
Reminder for reviewers