[#7173] Prevent error on disabled performance API #7175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
When performance API is disabled through
privacy.resistFingerprinting
setting in recent Firefox all API calls are possible thoughgetEntriesByName
will return an empty Array.This change checks the length of the returned array before using the first element in order not to cause a call to
undefined.duration
which breaks plugin architecture.closes #7173
How to test
In short: Enable
resistFingerprinting
in Firefox, ensure plugins are still loaded.Please see description of #7173 for further information.
Review checklist
Reminder for reviewers