Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#7173] Prevent error on disabled performance API #7175

Merged
merged 1 commit into from
Feb 19, 2020
Merged

[#7173] Prevent error on disabled performance API #7175

merged 1 commit into from
Feb 19, 2020

Conversation

Luzifer
Copy link
Contributor

@Luzifer Luzifer commented Feb 19, 2020

What it does

When performance API is disabled through privacy.resistFingerprinting setting in recent Firefox all API calls are possible though getEntriesByName will return an empty Array.

This change checks the length of the returned array before using the first element in order not to cause a call to undefined.duration which breaks plugin architecture.

closes #7173

How to test

In short: Enable resistFingerprinting in Firefox, ensure plugins are still loaded.

Please see description of #7173 for further information.

Review checklist

Reminder for reviewers

@akosyakov akosyakov added plug-in system issues related to the plug-in system browser/firefox issues related to the firefox browser labels Feb 19, 2020
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, please squash commits which fixing issues in the original commit, see https://github.com/eclipse-theia/theia/blob/master/doc/pull-requests.md#checklist-commit-history

Signed-off-by: Knut Ahlers <knut@ahlers.me>
@akosyakov akosyakov merged commit 33e1740 into eclipse-theia:master Feb 19, 2020
@Luzifer Luzifer deleted the 7173-prevent-error-on-disabled-performance-api branch February 19, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser/firefox issues related to the firefox browser plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin loading breaks when resistFingerprinting is enabled
2 participants