eslint: update 'no-multiple-empty-lines' rule #7184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pull-request updates the `eslint` `no-multiple-empty-lines` rule so that consecutive empty lines are forbidden and also fixes any violations. The default is to have **2** lines which is not the behavior we are looking for. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/empty-lines
branch
from
df0089b to
123e68e
Compare
kittaakos
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com
What it does
The pull-request updates the
eslintno-multiple-empty-linesrule so that consecutive empty lines are forbidden. The default is to have 2 lines which is not the behavior we are looking for.Motivation:
How to test
Update an existing TypeScript file to include 2 blank lines (
eslintshould now complain about the consecutive blank line).Review checklist
Reminder for reviewers