Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Lazily update frames of all threads in all-stop mode" #7272

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

marcdumais-work
Copy link
Contributor

Reverts #6869 because of this regression #7264

We're still looking for a fix that would avoid reverting #6969 - please do not merge this PR yet.

@marcdumais-work
Copy link
Contributor Author

cc: @marechal-p @akosyakov

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@akosyakov akosyakov added the debug issues that related to debug functionality label Mar 4, 2020
This reverts commit d1678ad.

Fixes #7272

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
@marcdumais-work marcdumais-work force-pushed the revert-6869-update-frame-upstream branch from 4354693 to ca299fb Compare March 4, 2020 18:04
@marcdumais-work
Copy link
Contributor Author

Merging as per #7264 (comment)

@marcdumais-work marcdumais-work merged commit d14f7c6 into master Mar 4, 2020
@marcdumais-work marcdumais-work deleted the revert-6869-update-frame-upstream branch March 4, 2020 18:05
lmcbout pushed a commit that referenced this pull request Mar 4, 2020
This reverts commit d1678ad.

Fixes #7272

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
@lmcbout lmcbout mentioned this pull request Mar 4, 2020
JesterOrNot pushed a commit to JesterOrNot/theia that referenced this pull request Mar 12, 2020
This reverts commit d1678ad.

Fixes eclipse-theia#7272

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants