Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron: fix backend forking #7386

Merged
merged 3 commits into from
Mar 27, 2020
Merged

electron: fix backend forking #7386

merged 3 commits into from
Mar 27, 2020

Commits on Mar 23, 2020

  1. electron: pass arguments to backend process

    When running a bundled application, the backend is forked. But any
    command line parameter passed to the Electron application isn't passed
    down to the backend. This commit makes sure that relevant arguments are
    passed to the forked backend process.
    
    Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
    paul-marechal committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    962c469 View commit details
    Browse the repository at this point in the history
  2. electron: patch process.versions.electron

    When forking, Electron 4 forgets to set `process.versions.electron` in
    the sub-process, making some packages wrongly guess their environment.
    This commit manually patches this variable.
    
    Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
    paul-marechal committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    5b6afb4 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2020

  1. electron: always fork except if --no-cluster

    The generated application code is not forking the backend when working
    from sources. Running the backend in the Electron main process was only
    meant to help with debugging. This commit makes the generated code fork
    the backend unless a `--no-cluster` flag is specified.
    
    Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
    paul-marechal committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    1714222 View commit details
    Browse the repository at this point in the history