Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null-check call result rather than function itself #7468

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Null-check call result rather than function itself #7468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions examples/api-tests/src/monaco-api.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,7 @@ describe('Monaco API', async function () {
}, {
label: 'Ctrl+Shift+Alt+K',
ariaLabel: 'Ctrl+Shift+Alt+K',
// eslint-disable-next-line no-null/no-null
electronAccelerator: null,
electronAccelerator: 'Ctrl+Shift+Alt+K',
userSettingsLabel: 'ctrl+shift+alt+K',
WYSIWYG: true,
chord: false,
Expand Down
2 changes: 1 addition & 1 deletion packages/monaco/src/browser/monaco-resolved-keybinding.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class MonacoResolvedKeybinding extends monaco.keybindings.ResolvedKeybind
}

public getElectronAccelerator(): string | null {
if (this.isChord) {
if (this.isChord()) {
// Electron cannot handle chords
// eslint-disable-next-line no-null/no-null
return null;
Expand Down