Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse DAP messages to match VS Code API #7517

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

dsseng
Copy link
Contributor

@dsseng dsseng commented Apr 7, 2020

What it does

Fixes #7470

How to test

Please see #7470 (comment)

Review checklist

Reminder for reviewers

Signed-off-by: Dmitry Sharshakov <d3dx12.xx@gmail.com>
@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Apr 7, 2020
@akosyakov
Copy link
Member

@sh7dm One has to create a simple drop-in VS Code extension and check that it works in VS Code and then in Theia. Such extension gets attached to the issue for others to test. Otherwise it is not clear how one ensure correctness.

@akosyakov akosyakov added the debug issues that related to debug functionality label Apr 8, 2020
@dsseng
Copy link
Contributor Author

dsseng commented Apr 8, 2020

@dsseng
Copy link
Contributor Author

dsseng commented Apr 8, 2020

Maybe we should ask issue author about how the issue was found and test in using their extension?

@akosyakov
Copy link
Member

@sh7dm If some extension is using it, that's also fine, then just write down how an extension should be used to confirm correctness. We will try that it does not work on master and compare to this branch.

@akosyakov
Copy link
Member

@dsseng
Copy link
Contributor Author

dsseng commented Apr 8, 2020

@akosyakov I tested this with updated extension by @ishche .
VS Code insiders:
image
Theia at 1453157:
image
Theia at 4442eb5 (this PR):
image

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, looks good, thank you!

@akosyakov akosyakov merged commit cb3db2a into eclipse-theia:master Apr 9, 2020
@dsseng dsseng deleted the parse-dap-messages branch April 9, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DebugAdapterTracker-onDidSendMessage(): theia sends string, vscode sends object
3 participants