Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix recently used quick-commands #7562

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes #7561

The following commit updates the quick-commands:

  • sort commands based on their display name (category and label) if applicable.
  • adds additional tests to verify sorting behavior.
  • fixes issue where recently used commands did not display the border separator and name.
Screen Shot 2020-04-13 at 2 29 56 PM

How to test

Refer #7561

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

Fixes #7561

The following commit updates the quick-commands:
- sort commands based on their display name (category and label) if applicable.
- adds additional tests to verify sorting behavior.
- fixes issue where recently used commands did not display the border separator and name.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added the commands issues related to application commands label Apr 13, 2020
@vince-fugnitto vince-fugnitto self-assigned this Apr 13, 2020
@vince-fugnitto vince-fugnitto requested a review from elaihau April 13, 2020 18:54
Copy link
Contributor

@Anasshahidd21 Anasshahidd21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested these changes against master and I can see the commands sorted. The seperator and the label also looks pretty good.

Looks good to me.

tested on Windows

Copy link
Contributor

@elaihau elaihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Gitpod.

Sorting looks good.
"The recently used" displays commands that are recently run, and can be cleared by "Clear command history."

Thank you Vincent !

@vince-fugnitto vince-fugnitto merged commit 37fa343 into master Apr 14, 2020
@vince-fugnitto vince-fugnitto deleted the vf/fix-quick-commands branch April 14, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commands issues related to application commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: fix quick-command service
3 participants