Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin] allow to override built-in commands #7592

Merged
merged 2 commits into from
Apr 16, 2020
Merged

[plugin] allow to override built-in commands #7592

merged 2 commits into from
Apr 16, 2020

Conversation

akosyakov
Copy link
Member

What it does

How to test

Review checklist

Reminder for reviewers

@akosyakov
[vscode] remove registration of commands provided by Monaco
e66fa8e 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov
[plugin] allow to override built-in commands
5a95d15 
to support VS Code Vim extension

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov added vim issues related to vim vscode issues related to VSCode compatibility labels Apr 16, 2020
@akosyakov
Copy link
Member Author

@tavoda Could you try this PR please?

RomanNikitenko
RomanNikitenko approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@RomanNikitenko RomanNikitenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a shallow testing:

  • switching between Normal, Insert, Visual mode
  • moving cursor by hjkl for Normal mode
  • typing in Insert mode
  • selection using hjkl for Visual mode

It works for me!

@akosyakov akosyakov merged commit 7217b4f into master Apr 16, 2020
@akosyakov akosyakov deleted the ak/vscode_vim branch April 16, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanNikitenko RomanNikitenko RomanNikitenko approved these changes

@vinokurig vinokurig Awaiting requested review from vinokurig

@AlexTugarev AlexTugarev Awaiting requested review from AlexTugarev

@vince-fugnitto vince-fugnitto Awaiting requested review from vince-fugnitto

Assignees
No one assigned
Labels
vim issues related to vim vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VSCODE VIM plugin not working
2 participants
@akosyakov @RomanNikitenko