Fix API tests on windows and add missing await on ts test #7655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amiram Wingarten <amiram.wingarten@sap.com>
|
@akosyakov is this missing await related to #7635 maybe? |
akosyakov
approved these changes
Apr 23, 2020
akosyakov
added
ci
|
Now travis fail on typescript.spec.js: �[0m�[31m Error: Timeout of 45000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.�[0m�[90m |
|
@amiramw I can reproduce it locally. It seems to be sometimes dispatching esc button happens too early and Monaco does not handle it. Looking into it. I will push a commit to this PR ok? I will reduce timeout back to 30s, i've increased it because could not understand flakiness, but it was missing await. |
|
sure. thanks! |
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
|
Pushed. There were a race in tests, that close happens before the peek widget was actually focused. Merging if the build is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amiram Wingarten amiram.wingarten@sap.com
What it does
Fixes #7644
Fixes API tests on windows and add missing await on typescript.spec.js.
How to test
Run
yarn test:browseron windows and see that it completes successfuly.Review checklist
Reminder for reviewers