Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve handling of mime associations #7805

Merged
merged 2 commits into from
May 14, 2020

Conversation

akosyakov
Copy link
Member

What it does

How to test

Review checklist

Reminder for reviewers

akosyakov added 2 commits May 13, 2020 08:59
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov
Copy link
Member Author

@joazvsoares Could you try against this PR?

@akosyakov akosyakov added the monaco issues related to monaco label May 13, 2020
@akosyakov akosyakov requested a review from RomanNikitenko May 13, 2020 09:18
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified the changes against #7791 and they work correctly 👍


I've performed the following steps:

  1. added the necessary php builtin and external vscode extensions (as described in the issue).
  2. created both a test.php and test.txt file in the workspace.
  3. created a file association such as:
{
  "files.associations": {
      "*.php": "php",
      "*.txt": "php"
  }
}
  1. verified that both test.php and test.txt are both syntax-highlighted and contains completion as if they were php files.
  2. verified that the previous step remains true when the application is reloaded.
Screen Shot 2020-05-13 at 8 30 08 AM

@akosyakov akosyakov merged commit 83f6c03 into master May 14, 2020
@akosyakov akosyakov deleted the akosyakov/files-associations-is-7791 branch May 14, 2020 07:04
@joazvsoares
Copy link

Thanks for jumping into this and for getting the fix ready so fast!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monaco issues related to monaco
Projects
None yet
3 participants