Bind command for explorer.newFolder

[vzhukovs]

What it does

This changes proposal adds bind for VS Code built-in command explorer.newFolder [1].

[1] microsoft/vscode/src/vs/workbench/contrib/files/browser/fileActions.ts#L112-L131

Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com

How to test

Needed for Didact extension.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[akosyakov]

Needed for Didact extension.

Are there steps to trigger these commands by using this extension?

[vzhukovs]

Needed for Didact extension.

Are there steps to trigger these commands by using this extension?

Sure.

Triggering explorer.newFolder:

[azatsarynnyy]

explorer.newFolder works well for me
but after triggering workbench.view.explorer I've got the following error in the browser's console:

rpc-protocol.ts:376 Uncaught (in promise) TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'SplitPanel'
    |     property '_layout' -> object with constructor 'ViewContainerLayout'
    --- property '_parent' closes the circle
    at JSON.stringify (<anonymous>)
    at Function.push.../../packages/plugin-ext/lib/common/rpc-protocol.js.MessageFactory.replyOK (rpc-protocol.ts:376)
    at rpc-protocol.ts:231

[akosyakov]

Maybe because of https://github.com/eclipse-theia/theia/pull/7851/files#r428107565?

[vzhukovs]

explorer.newFolder works well for me
but after triggering workbench.view.explorer I've got the following error in the browser's console:

rpc-protocol.ts:376 Uncaught (in promise) TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'SplitPanel'
    |     property '_layout' -> object with constructor 'ViewContainerLayout'
    --- property '_parent' closes the circle
    at JSON.stringify (<anonymous>)
    at Function.push.../../packages/plugin-ext/lib/common/rpc-protocol.js.MessageFactory.replyOK (rpc-protocol.ts:376)
    at rpc-protocol.ts:231

Created sample plugin, that simply calls Theia's internal command workbench.files.action.focusFilesExplorer, and it seems that there is a problem with serialization objects. Issue reproduces with custom plugin.

Created following depends on issue.

[vzhukovs]

Updated description w/ PR's title. Excluded bind for workbench.view.explorer command.

[azatsarynnyy]

I've checked it again with Red Hat Didact extension. Create Folder command works well.