[Terminal] Detach TerminalSearchWidget before disposing TerminalWidget #7882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes - eclipse-theia#7625 Signed-off-by: Balaji Vijayakumar <kuttibalaji.v6@gmail.com>
|
Tested. On close terminal widget I don't see any errors in the browser console. |
AndrienkoAleksandr
approved these changes
May 26, 2020
|
@AndrienkoAleksandr don't forget to help with merging, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Balaji Vijayakumar kuttibalaji.v6@gmail.com
What it does
Fixes - #7625
This commit detaches the TerminalSearchWidget before disposing TerminalWidget.
How to test
Review checklist
Reminder for reviewers