-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/Stringify Task ENUMs for Presentation and PanelKind #7982
Bugfix/Stringify Task ENUMs for Presentation and PanelKind #7982
Conversation
Signed-off-by: Kenneth Marut <kenneth.marut@ericsson.com>
@elaihau do you have time to review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this change in my local environment. It worked properly. Thank you for the work !
@akosyakov fine to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the corresponding API objects use different values. VS Code has other values as well.
So we should test some Theia
plugin or VS Code
extension which uses these objects to avoid regression from plugin side.
I can check this use case today, sorry for the delay...
@elaihau Ready to merge I think? |
@marcdumais-work Yes. I don't see objections from Roman either. |
Please do the honours, Liang |
Oui chef |
thanks for the review + merge ✌ |
What it does
This PR addresses #7956 where
ENUM
values forPanelKind
andRevealKind
were not properly being stringified to their values defined in thetask-schema-updated.ts
(referenced below) when using.setTaskConfigurations()
to write tasks to atasks.json
file, causing anInvalid task configurations are found
error :theia/packages/task/src/browser/task-schema-updater.ts
Line 572 in 309b218
theia/packages/task/src/browser/task-schema-updater.ts
Line 583 in 309b218
How to test
enum types for presentation panel and reveal, for example:
Attempt to call this.taskConfigurationManager.setTaskConfigurations(scopeURI, [pendingTaskConfiguration])
Open corresponding tasks.json file and observe that reveal and panel values have been properly set to their string values and no errors are thrown.
Review checklist
Reminder for reviewers