Remove slash at the end of extension path

[vitaliy-guliy]

Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com

What it does

Removes the last slash from the extensionPath, which is passed to the extension withing PluginContext.

I didn't find any rules about the slash at the ending of PluginContext.extensionPath on the VS Code API.
A sample helloworld extension running in VS Code prints the path without the slash.

vscode.window.showInformationMessage(`ExtensionPath [${context.extensionPath}]`);

This fix is necessary for some extensions, e.g. Jira and Bitbucket.
Actually we are trying to run this extension inside Che-Theia eclipse-che/che#17081, but faced the problem, that the extension forms wrong URI to some webview resources (URI contains double slashes in the Path).

https://serverj5kpkbom-jwtproxy-webviews.192.168.99.152.nip.io/webview/theia-resource/file/tmp/vscode-unpacked/atlascode-0.0.0.vsix/extension//build/static/js/vendors~atlascodeCreateIssueScreen~atlascodeOnboardingV2~atlascodeSettingsV2~bitbucketIssuePageV2~cr~8893e30c.755b5343.chunk.js

Removing the slash at the end of extensionPath solved the issue.

How to test

Currently it's difficult to test how vanilla Theia works with Jira and Bitbucket extension.
But the reviewer can build Theia and try to run any extension, which use PluginContext.extensionPath.
I don't know such plugin, except Jira&Bitbucket. Any other extensions I know works fine.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[akosyakov]

Actually we are trying to run this extension inside Che-Theia eclipse-che/che#17081, but faced the problem, that the extension forms wrong URI to some webview resources (URI contains double slashes in the Path).

Do you know where such URIs is created? It could be that such place violating one of rules here: https://github.com/eclipse-theia/theia/wiki/Coding-Guidelines#uripath Like using path instead of uri and manipulating paths as strings

[vitaliy-guliy]

Do you know where such URIs is created? It could be that such place violating one of rules here: https://github.com/eclipse-theia/theia/wiki/Coding-Guidelines#uripath Like using path instead of uri and manipulating paths as strings

URI is created in the extension, and this extension operates with strings, not with URIs.
But this URI is based on the extensionPath ( API int theia.d.ts )
It should not violate anything.

[akosyakov]

not sure about removing normalize that's to get rid of .. and . in the path, don't think it is related to trailing slashes

[vitaliy-guliy]

Is it better to resolve the path?
just

pluginPath = path.resolve(pluginPath);

[vitaliy-guliy]

Checked the code again. I think the caller of readPackage must care about the correct path. Further in the code, path.join is used to concatenate the path elements.
Normalizing or resolving the path here is a bit redundant.

[akosyakov]

@amiramw Could you check please that it does not introduce regressions for #5274? Generally we should use portable URI here to abstract away from OS quirks, but if it does not break i'm fine to merge like that.

[vitaliy-guliy]

is there any verdict on this PR?

[akosyakov]

@vitaliy-guliy could you clean the history please: https://github.com/eclipse-theia/theia/blob/master/doc/pull-requests.md#checklist-commit-history and i will test afterwards?

[vitaliy-guliy]

@akosyakov squashed to one commit

[akosyakov]

smoked tests built-in extensions against both targets, everything seem to be loaded normal