-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debug: add run statusbar item #8134
Conversation
Is it configurable in VS Code? |
I was previously unaware of any configuration, but verifying I found the following preference which controls the behavior: |
607d96d
to
b81e6a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not tried, but code changes look good.
b81e6a3
to
81feea2
Compare
- adds the `select and run` statusbar item for debugging. - the item is registered when a debug session starts, and reflects the current configuration. - triggering the item will prompt the debug prefix quick-open menu. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
81feea2
to
1a9e8bc
Compare
@vince-fugnitto could you assign someone to test it please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes work well for me.
I verified by running mocha test on theia workspace(the preference value was set to onFirstSessionStart
).
Tested the value never
and always
.
The status bar correctly updates with the change in configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Works well
Could be in a separate PR: It would be nice to the end-user to know which value is the default value for any preferences when selecting it. In this case, by reading the code I can see it (default: 'onFirstSessionStart')
You can't always rely on the default preference value in the code, since the default can easily be overridden in the application's
Sounds like you're suggesting a potential Preferences widget improvement? However pretty orthogonal to this PR here, so if you care, you should open a separate issue about it, if none exist yet. |
As a developper of Theia, I can open the file and see the default value. As a end-user, the only thing I see is in the preference setting while running Theia, I don't look inside the code to find the default value. I did an extra test and in VSCode, the default value is identified in the preference setting. If we try to align Theia with VSCode, then the default value is not identified I don't know about the other preferences default setting, i was just looking at the preference setting for this issue. |
What it does
Fixes: #5156
The following pull-request implements the select and run debug statusbar item:
debug.showInStatusBar
How to test
Verify that the debug status bar item is updated accordingly based on the preference value, and the configuration updates:
never
: the debug status bar item is never displayed, if previously displayed it will be removedalways
: the debug status bar item is always displayed (on app start as well)onFirstSessionStart
: the debug status bar item is displayed on a debug session is first startedExample: updating the configuration changes the label
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com