GH-815: Bumped up the node-pty version. #816
Conversation
The new version is intentionally 0.7.1 to be sync with VSCode. Signed-off-by: Akos Kitta <kittaakos@gmail.com>
|
So the only reason is to be in sync ? why do we want to be ? |
| @@ -4,7 +4,7 @@ | |||
| "description": "Theia process support.", | |||
| "dependencies": { | |||
| "@theia/core": "^0.2.0", | |||
| "node-pty": "^0.7.0" | |||
| "node-pty": "^0.7.1" | |||
There was a problem hiding this comment.
They have a broken build. But this did not fix anything. So does not matter.
|
Did not fix anything. I am closing this. |
|
I think in general it is good to upgrade our deps to latest releases, since usually they include fixes. |
I agree. So that's why I went to their CIs, checked the history and they had to trigger the builds three times to be able to release.
|
|
See also #817 since RawProcess/TerminalProcess have more testing into the process exit etc... It may fix the issue. |
Cool, thanks! Let me try. It is just complicated to bundle an application from the Theia source. |
|
Test flakiness was caused by microsoft/node-pty#159 (fixed in 0.7.3). |
The new version is intentionally 0.7.1 to be sync with VSCode.
Closes #815.
Signed-off-by: Akos Kitta kittaakos@gmail.com