Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[preferences] Unused static variable #8249

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

minyoungyang
Copy link
Contributor

Fixes #8201

What it does

  • Deleted unused static variable from preference-widget.tsx

How to test

  • Build all extensions
  • Open preference widget

Review checklist

Reminder for reviewers

Signed-off-by: Min-young Yang didalsdud@gmail.com

Fixes: eclipse-theia#8201

Deleted unused static (PreferenceWidget.COMMAND_LABEL)

Signed-off-by: Min-young Yang <didalsdud@gmail.com>
@vince-fugnitto vince-fugnitto added preferences issues related to preferences quality issues related to code and application quality labels Jul 28, 2020
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, I verified that the static constant is in fact not used.

@vince-fugnitto vince-fugnitto merged commit 8969486 into eclipse-theia:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preferences issues related to preferences quality issues related to code and application quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[quality][preferences] PreferencesWidget#COMMANDL_LABEL is unused
2 participants