normalize base of language filter pattern to support clients on another OS #8268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
force-pushed
the
ak/normalize_pattern_base
branch
from
56a4ee4 to
2772011
Compare
|
@eclipse-theia/ecd-theia-committers Can someone with Windows machine help to verify? Backend should run on Linux (you can just use Gitpod). |
akosyakov
added
OS/Windows
tsmaeder
approved these changes
Jul 30, 2020
| @@ -40,7 +40,6 @@ import { | |||
| MarkerSeverity, DocumentLink, WorkspaceSymbolParams, CodeAction, CompletionDto | |||
| } from '../../common/plugin-api-rpc-model'; | |||
| import { RPCProtocol } from '../../common/rpc-protocol'; | |||
| import { fromLanguageSelector } from '../../plugin/type-converters'; | |||
There was a problem hiding this comment.
This method is now unreferenced. Can we remove it? It looks kinda fishy anyway.
It also removes dependencies to the plugin process code from the main process. Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov
force-pushed
the
ak/normalize_pattern_base
branch
from
2772011 to
6021f3a
Compare
1 task
vince-fugnitto
approved these changes
Jul 30, 2020
|
Code wise looks good, Anyone with a window environment can perform a last check before merging for the release would be appreciated. Thanks |
|
Thomas already checked on windows against linux: #8268 (review) |
|
Good, You should merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
How to test
ExtensionsviewReview checklist
Reminder for reviewers