security: update 'decompress' dependency #8294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
security
vince-fugnitto
force-pushed
the
vf/decompress
branch
from
14b43fe to
e553543
Compare
vince-fugnitto
force-pushed
the
vf/decompress
branch
from
e553543 to
329615d
Compare
|
@marcdumais-work thank you for the review, I've updated the code based on your feedback. |
vince-fugnitto
force-pushed
the
vf/decompress
branch
from
329615d to
35409d8
Compare
marcdumais-work
approved these changes
Aug 4, 2020
There was a problem hiding this comment.
LGTM, thanks @vince-fugnitto . Maybe we can wait for a couple of days before merging in case more committers want to review?
Sure, I'll wait a couple of days, I can merge Monday 👍 |
amiramw
approved these changes
Aug 5, 2020
The following commit updates the `decompress` dependency to benefit from the security vulnerability fix. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/decompress
branch
from
35409d8 to
e62c077
Compare
|
@marcdumais-work fine to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #7319
The following pull-request updates the decompress dependency (used by the plugin system), to fix the known security vulnerability in versions less than
<4.2.1(https://snyk.io/vuln/npm:decompress).How to test
4.2.1innode_modules/Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com