-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix regressions related to tasks support #8340
Conversation
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes work well, I verified that:
- user-level tasks
- tasks run successfully
- the schemas work correctly, including hover information and problem markers
- workspace-level tasks
- tasks run successfully
- the schemas work correctly, including hover information and problem markers
- launch
- debug sessions run successfully
- the schema works correctly, including hover information and problem markers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akosyakov
The changes are meaningful and look good to me, but unfortunately they don't fix #8230 for me :-(
I played with your changes and still can reproduce the issue:
- I had
theia
andvscode
folders in my workspace - I tried to edit
tasks.json
file fromtheia
folder, then edittasks.json
file fromvscode
folder - it happens not at refreshing page, but within editing
tasks.json
file - usually it takes a few minutes to face with the issue
- I can reproduce permanently similar problem for
settings.json
at refreshing page
Please see a few videos.
tasks.json problem
https://youtu.be/ZsO3H-yN9DM
https://youtu.be/KBLBarHtVL0
@RomanNikitenko sorry was too fast, i am checking again |
For settings I think it is not a regressions, but an enhancement to support different kind of settings schema: https://github.com/microsoft/vscode/blob/2277c8e2a3e1cc630a6397301ba54a1dccd8a60d/src/vs/workbench/services/configuration/common/configuration.ts#L12-L17 I will file an issue. |
An issue to support all setting schemas: #8349 |
What it does
How to test
Review checklist
Reminder for reviewers