Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regressions related to tasks support #8340

Merged
merged 2 commits into from
Aug 11, 2020

Conversation

akosyakov
Copy link
Member

What it does

How to test

  • test that you can create user and workspace tasks
  • test that tasks.json and launch.json files have schema support

Review checklist

Reminder for reviewers

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov added the tasks issues related to the task system label Aug 10, 2020
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work well, I verified that:

  • user-level tasks
    • tasks run successfully
    • the schemas work correctly, including hover information and problem markers

  • workspace-level tasks
    • tasks run successfully
    • the schemas work correctly, including hover information and problem markers

  • launch
    • debug sessions run successfully
    • the schema works correctly, including hover information and problem markers

@akosyakov akosyakov merged commit 614120b into master Aug 11, 2020
@akosyakov akosyakov deleted the akosyakov/task-schema-support-stops-8230 branch August 11, 2020 05:03
Copy link
Contributor

@RomanNikitenko RomanNikitenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akosyakov
The changes are meaningful and look good to me, but unfortunately they don't fix #8230 for me :-(

I played with your changes and still can reproduce the issue:

  • I had theia and vscode folders in my workspace
  • I tried to edit tasks.json file from theia folder, then edit tasks.json file from vscode folder
  • it happens not at refreshing page, but within editing tasks.json file
  • usually it takes a few minutes to face with the issue
  • I can reproduce permanently similar problem for settings.json at refreshing page

Please see a few videos.

tasks.json problem
https://youtu.be/ZsO3H-yN9DM
https://youtu.be/KBLBarHtVL0

settings.json problem:
settings_problem

@akosyakov
Copy link
Member Author

@RomanNikitenko sorry was too fast, i am checking again

@akosyakov
Copy link
Member Author

For settings I think it is not a regressions, but an enhancement to support different kind of settings schema: https://github.com/microsoft/vscode/blob/2277c8e2a3e1cc630a6397301ba54a1dccd8a60d/src/vs/workbench/services/configuration/common/configuration.ts#L12-L17 I will file an issue.

@akosyakov
Copy link
Member Author

An issue to support all setting schemas: #8349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks issues related to the task system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task schema support stops working
3 participants