GH-8350: Fixed bogus app config defaults. #8355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #8350 Signed-off-by: Akos Kitta <kittaakos@typefox.io>
akosyakov
reviewed
Aug 12, 2020
akosyakov
reviewed
Aug 12, 2020
| @@ -20,6 +20,7 @@ import { NpmRegistry, NodePackage, PublishedNodePackage, sortByKey } from './npm | |||
| import { Extension, ExtensionPackage, RawExtensionPackage } from './extension-package'; | |||
| import { ExtensionPackageCollector } from './extension-package-collector'; | |||
| import { ApplicationProps } from './application-props'; | |||
| const merge = require('deepmerge'); | |||
There was a problem hiding this comment.
it does not seem to be type safe
akosyakov
approved these changes
Aug 12, 2020
There was a problem hiding this comment.
it works, thanks! I am not sure though about how deepmerge works under the hood: https://github.com/eclipse-theia/theia/pull/8355/files#r469011994
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8350
Signed-off-by: Akos Kitta kittaakos@typefox.io
What it does
Fixes the bogus default handling for application props.
How to test
applicationNamefromexamples/browser/package.json,yarn --cwd ./examples/browser build,applicationNameisEclipse Theiain the generatedexamples/browser/src-gen/frontend/index.js.Or verify it with a VS Code extension. See here.
Review checklist
Reminder for reviewers