-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream webview resources to avoid blocking a web socket #8359
Conversation
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
dc33ea2
to
570ebe9
Compare
installed, but with error after reload it seems to be activated, at least the python selection was computed in background 👍 creating a new notebook is slow for the first time, I bet the reason is the local notebook server which is spinning up in background. after reload, a new notebook is opened within ~5 seconds. |
@akosyakov, how to you measure |
BTW, |
UPDATE: #8359 (comment) is probably caused by some cache issues. Other than that, it's working, but not very fast, mainly because it takes quite some time to load the resources from the python extension. the biggest fish is "ipywidgets.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works good. The performance really depends on the size of the resources needs to be loaded.
Just a note I've used actually a version from MS marketplace which is much smaller than from the open vsx reigstry. That's why it is fast for me to open notebooks. The version in the open vsx registry should be fixed. |
Can you file an issue at https://github.com/eclipse/open-vsx.org/issues please if necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not measured the loading time but I did not see much difference trying it.
@brianking It was fixed yesterday: EclipseFdn/publish-extensions#115 @azatsarynnyy I think you can try to install the system proxy to emulate the bad connection. It should make it very visible that before you won't be able to do any other requests to the backend while notebooks are openning. |
What it does
How to test
Create New Blank Jupyter Notebook
Review checklist
Reminder for reviewers