Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream webview resources to avoid blocking a web socket #8359

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

akosyakov
Copy link
Member

What it does

How to test

  • install python extension from open vsx registry
  • call Create New Blank Jupyter Notebook
  • UI should not be blocked, the notebook should be loaded promptly

Review checklist

Reminder for reviewers

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov force-pushed the ak/stream_webview_resources branch from dc33ea2 to 570ebe9 Compare August 12, 2020 08:41
@akosyakov akosyakov added performance issues related to performance webviews issues related to webviews labels Aug 12, 2020
@AlexTugarev
Copy link
Contributor

install python extension from open vsx registry

installed, but with error

Screen Shot 2020-08-12 at 10 59 08

after reload it seems to be activated, at least the python selection was computed in background 👍

creating a new notebook is slow for the first time, I bet the reason is the local notebook server which is spinning up in background.

after reload, a new notebook is opened within ~5 seconds.
when trying to navigate the directories in the explorer view, it seems to be blocking for a second or so.

@AlexTugarev
Copy link
Contributor

@akosyakov, how to you measure notebook should be loaded promptly?

@AlexTugarev
Copy link
Contributor

BTW, Uncaught (in promise) Error: Illegal theme base! is logged a few times.

@AlexTugarev
Copy link
Contributor

Screen Shot 2020-08-12 at 11 11 59

is this known or new?

@AlexTugarev
Copy link
Contributor

UPDATE:

#8359 (comment) is probably caused by some cache issues.

Other than that, it's working, but not very fast, mainly because it takes quite some time to load the resources from the python extension. the biggest fish is "ipywidgets.js"

Screen Shot 2020-08-12 at 11 47 04

Copy link
Contributor

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works good. The performance really depends on the size of the resources needs to be loaded.

@akosyakov
Copy link
Member Author

akosyakov commented Aug 12, 2020

@akosyakov, how to you measure notebook should be loaded promptly?

Just a note I've used actually a version from MS marketplace which is much smaller than from the open vsx reigstry. That's why it is fast for me to open notebooks. The version in the open vsx registry should be fixed.

@brianking
Copy link

@akosyakov, how to you measure notebook should be loaded promptly?

Just a note I've used actually a version from MS marketplace which is much smaller than from the open vsx reigstry. That's why it is fast for me to open notebooks. The version in the open vsx registry should be fixed.

Can you file an issue at https://github.com/eclipse/open-vsx.org/issues please if necessary.

Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not measured the loading time but I did not see much difference trying it.

@akosyakov akosyakov merged commit bfd9e03 into master Aug 13, 2020
@akosyakov
Copy link
Member Author

@brianking It was fixed yesterday: EclipseFdn/publish-extensions#115

@azatsarynnyy I think you can try to install the system proxy to emulate the bad connection. It should make it very visible that before you won't be able to do any other requests to the backend while notebooks are openning.

@akosyakov akosyakov deleted the ak/stream_webview_resources branch August 13, 2020 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance issues related to performance webviews issues related to webviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loading python notebooks is slow
4 participants