Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy: fix deploy stage during CI #8367

Merged
merged 1 commit into from
Aug 12, 2020
Merged

deploy: fix deploy stage during CI #8367

merged 1 commit into from
Aug 12, 2020

Conversation

vince-fugnitto
Copy link
Member

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

What it does

Fixes: #8365

The following pull-request fixes the deploy stage of the build (used to publish extensions to npm), which currently fails
as it is unable to find the node version. The previous change did not resolve the issue: #8362

How to test

N/A

Review checklist

Reminder for reviewers

the following pull-request fixes the deploy stage of the build
(used to publish extensions to `npm`), which currently fails
as it is unable to find the `node` version.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added bug bugs found in the application ci issues related to CI / tests labels Aug 12, 2020
@vince-fugnitto vince-fugnitto self-assigned this Aug 12, 2020
Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please wait for CI to successfully finish before merging

@vince-fugnitto
Copy link
Member Author

vince-fugnitto commented Aug 12, 2020

LGTM - please wait for CI to successfully finish before merging

Merging, the CI is green, hopefully the build stage now passes 🤞

@vince-fugnitto vince-fugnitto merged commit fb8dfab into master Aug 12, 2020
@vince-fugnitto vince-fugnitto deleted the vf/fix-deploy branch August 12, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application ci issues related to CI / tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deploy: 'deploy' stage failing with incorrect node version
2 participants