electron: fix rebuild:electron command

[vince-fugnitto]

What it does

The following commit fixes the rebuild:electron command to include drivelist as part of the list of native modules to rebuild for the electron target. The pull-request fixes an issue where the electron app fails to start.

How to test

1. perform yarn start:electron.
2. the application should successfully start again.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

[marcdumais-work]

LGTM, thanks Vince!

Tested on Gitpod.

[paul-marechal]

Works for me too.

[kittaakos]

The pull-request fixes an issue where the electron app fails to start.

Do you have a link to the error or the bug report? I wonder why it became suddenly mandatory and why wasn't is a problem in the last 2-3 years? Or was it related to dependency updates? Thanks!

[vince-fugnitto]

The pull-request fixes an issue where the electron app fails to start.

Do you have a link to the error or the bug report? I wonder why it became suddenly mandatory and why wasn't is a problem in the last 2-3 years? Or was it related to dependency updates? Thanks!

Yes, it was related to the prior commit for the yarn upgrade: e198c7c
Sorry, I should have opened an issue first then fixed it (we experienced the issue locally and internally after the commit).

[kittaakos]

Yes, it was related to the prior commit for the yarn upgrade: e198c7c
Sorry, I should have opened an issue first then fixed it (we experienced the issue locally and internally after the commit).

No worries, and thank you!

[christlee1989]

@vince-fugnitto Why i still have error

[kittaakos]

You have to run yarn rebuild:electron. Did you do that?

[christlee1989]

You have to run yarn rebuild:electron. Did you do that?

[kittaakos]

Hmm, interesting; I never run a Theia build after the electron rebuild but the other way around. Did this work for you earlier? Do you have a public repo I can try?

[christlee1989]

Hmm, interesting; I never run a Theia build after the electron rebuild but the other way around. Did this work for you earlier? Do you have a public repo I can try?

I used https://github.com/eclipse-theia/theia-example , changed all dependencies version to 'next' , then run yarn, then yarn start

[kittaakos]

I used https://github.com/eclipse-theia/theia-example , changed all dependencies version to 'next' , then run yarn, then yarn start

I did not know this repo exists. Do not use it. Use these steps instead: https://github.com/eclipse-theia/theia/blob/master/doc/Developing.md#quick-start

[christlee1989]

I used https://github.com/eclipse-theia/theia-example , changed all dependencies version to 'next' , then run yarn, then yarn start

I did not know this repo exists. Do not use it. Use these steps instead: https://github.com/eclipse-theia/theia/blob/master/doc/Developing.md#quick-start

ok, ill try it , thx.

[kittaakos]

ok, ill try it , thx.

👍 Let us know if you're still having issues.

[christlee1989]

ok, ill try it , thx.

👍 Let us know if you're still having issues.

no error now, but I want to know why theia-example has issue. I want to build my own IDE , could you tell me how to start ? is there any useable & complete example？

[christlee1989]

The goal is to eventually generate a desktop version IDE

[kittaakos]

but I want to know why theia-example has issue.

You should open an issue there and not comment on a closed PR.

I want to build my own IDE , could you tell me how to start

• https://github.com/theia-ide/theia-apps
• https://theia-ide.org/docs/composing_applications/

[christlee1989]

ok thx

[marcdumais-work]

no error now, but I want to know why theia-example has issue.

@christlee1989 I think theia-example is a valid example, just not for what you are trying to achieve: That repo has an Electron-only example app and from it we produce a signed, packaged application, for multiple platforms.

Please follow the advise above and inspire yourself from a more generic example.