Issue-8310

[esterw1109]

Issue-8310: Deprecated code completions crash
Signed-off-by: Esther Perelman wwr1109@gmail.com

What it does

Fixes #8310
Fixes #8475

How to test

Steps to reproduce on #8310

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[danidoedel]

I guess #8475 is related and this change will fix it as well?

[vince-fugnitto]

Thank you for your contribution @esterw1109 👍
Please be sure to sign-off your commit so we can accept the changes (it is necessary for the eca check).

[esterw1109]

Thank you for your contribution @esterw1109 👍
Please be sure to sign-off your commit so we can accept the changes (it is necessary for the eca check).

I have signed-off my commit but it's still has an error, What can it be?

[amiramw]

Thank you for your contribution @esterw1109 👍
Please be sure to sign-off your commit so we can accept the changes (it is necessary for the eca check).

I have signed-off my commit but it's still has an error, What can it be?

https://github.com/eclipse-theia/theia/blob/master/CONTRIBUTING.md#eclipse-contributor-agreement

[vince-fugnitto]

@esterw1109 I see that you have signed-off your commit and your ECA is valid:

The issue is that your authorship email does not match your sign-off (git log):

commit c40abaef09b0095bffd89a05d4e125abf1a2bb5f (HEAD -> esterw1109-8310-Deprecated-code-completions-crash)
Author: Esther Perelman <34027100+esterw1109@users.noreply.github.com>
Date:   Thu Sep 17 13:23:10 2020 +0300

    Issue-8310
    
    Issue-8310: Deprecated code completions crash
    Signed-off-by: Esther Perelman <wwr1109@gmail.com>

[esterw1109]

@vince-fugnitto Thanks! That was the problem I changed my author-email and recreate a PR on #8517
Should I close current PR?

[vince-fugnitto]

@vince-fugnitto Thanks! That was the problem I changed my author-email and recreate a PR on #8517
Should I close current PR?

I'll close it for you, thank you for providing the fix 👍