Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for Label Provider and Contribution #8569

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

JonasHelming
Copy link
Contributor

@JonasHelming JonasHelming commented Sep 29, 2020

fixes #8568

Contributed on behalf of STMicroelectronics

Signed-off-by: Jonas Helming jhelming@eclipsesource.com

What it does

Adds documentation to LabelProvider and LabelProviderContribution

How to test

Documentation changes only

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto changed the title Added docu for Label Provider and Contribution Added documentation for Label Provider and Contribution Sep 29, 2020
@vince-fugnitto vince-fugnitto added the documentation issues related to documentation label Sep 29, 2020
packages/core/src/browser/label-provider.ts Outdated Show resolved Hide resolved
packages/core/src/browser/label-provider.ts Outdated Show resolved Hide resolved
packages/core/src/browser/label-provider.ts Outdated Show resolved Hide resolved
packages/core/src/browser/label-provider.ts Outdated Show resolved Hide resolved
packages/core/src/browser/label-provider.ts Outdated Show resolved Hide resolved
packages/core/src/browser/label-provider.ts Outdated Show resolved Hide resolved
packages/core/src/browser/label-provider.ts Outdated Show resolved Hide resolved
@JonasHelming JonasHelming force-pushed the labelprovider branch 2 times, most recently from bbd37af to 85c769d Compare October 2, 2020 13:15
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While addressing the following comments, can you also update the commit message, at the moment there are typos as well:

Added docu for Label Provider

packages/core/src/browser/label-provider.ts Outdated Show resolved Hide resolved
packages/core/src/browser/label-provider.ts Outdated Show resolved Hide resolved
fixes eclipse-theia#8568

Contributed on behalf of STMicroelectronics

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation updates look good to me @JonasHelming, thank you for the contribution!

@vince-fugnitto
Copy link
Member

@JonasHelming are there other edits you expect to include, or need help with a merge?

@JonasHelming
Copy link
Contributor Author

merge would be fine!

@vince-fugnitto vince-fugnitto merged commit 8ff85ba into eclipse-theia:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation to LabelProvider and LabelProviderContribution
3 participants