Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: allow customizing CommandQuickOpenItem #8648

Merged
merged 1 commit into from
Oct 21, 2020
Merged

core: allow customizing CommandQuickOpenItem #8648

merged 1 commit into from
Oct 21, 2020

Conversation

shahar-h
Copy link
Contributor

Signed-off-by: Shahar Harari shahar.harari@sap.com

What it does

  • Allow customizing CommandQuickOpenItem without rewriting init method in QuickCommandService.
  • Removed deprecated API usages in quick-command-service.

How to test

Check that commands execution from quick-open UI still works.

Review checklist

Reminder for reviewers

@shahar-h
core: Allow customizing CommandQuickOpenItem
f07e136 
Signed-off-by: Shahar Harari <shahar.harari@sap.com>
@kittaakos
Copy link
Contributor

  • Removed deprecated API usages in quick-command-service.

Thanks for taking care of the code 👍

@kittaakos kittaakos merged commit 60def53 into eclipse-theia:master Oct 21, 2020
@shahar-h shahar-h deleted the customize-quick-open branch October 21, 2020 13:15
@shahar-h
Copy link
Contributor Author

Thanks @kittaakos

@amiramw amiramw mentioned this pull request Jan 6, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittaakos kittaakos kittaakos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shahar-h @kittaakos