Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Workaround for Electron not installing a handler to ignore SIGPIPE error #8661

Merged

Conversation

zhaomenghuan
Copy link
Contributor

@zhaomenghuan zhaomenghuan commented Oct 22, 2020

What it does

Fixes #8534

  • Workaround for Electron Backend Process not installing a handler to ignore SIGPIPE errors.

How to test

I have tested my application and related issues have been resolved. https://github.com/eclipse-theia/theia/issues/8534

Review checklist

Reminder for reviewers

Signed-off-by: zhaomenghuan zhaomenghuan02@meituan.com

…IPE error

Signed-off-by: zhaomenghuan <zhaomenghuan02@meituan.com>
@kittaakos
Copy link
Contributor

@zhaomenghuan, thank you again! What OS are you using? I would like to reproduce the issue with and without your changes; do I have to hibernate my OS and that's all I have to do?

@zhaomenghuan
Copy link
Contributor Author

@kittaakos I am using macOS. I can't reproduce the problem with the theia examples and Arduino Pro IDE. Currently, it can only be reproduced in the application I built.

@kittaakos
Copy link
Contributor

I am using macOS.

👍 Thanks for the info. Me too, at least this simplifies the verification.

I can't reproduce the problem with the theia examples and Arduino Pro IDE. Currently, it can only be reproduced in the application I built.

Good to know.

I was not aware of it, but macOS can be configured to go to hibernation mode instead of sleep with pmset. Did you tune pmset on your side?

@zhaomenghuan
Copy link
Contributor Author

In my impression, I haven't made any settings about pmset, and used the default behavior of the system. If SIGPIPE is not processed in my application, the process will die in sleep mode. I have analyzed the memory-related data and can confirm that it is normal.

@kittaakos
Copy link
Contributor

OK, fair enough. Your contribution is super useful for Electron clients; I will figure out how to reproduce it locally and try to merge the PR this week so it will be part of the next release.

Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified it with the demo version of SmartSleep on macOS: QuickSleep > Hibernate Now. It works great 👍

@kittaakos kittaakos merged commit ecfe920 into eclipse-theia:master Oct 22, 2020
@zhaomenghuan zhaomenghuan deleted the fix/ignore-sigpipe-error branch February 21, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants