Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: Add support for activeColorTheme and onDidChangeActiveColorTheme API #8710

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

DucNgn
Copy link
Contributor

@DucNgn DucNgn commented Nov 4, 2020

CQ

What it does

Closes #8635

  • Supports:
    • activeColorTheme API: check what the current theme kind is (Light, Dark, or HighContrast)
    • onDidChangeActiveColorTheme API that fires an event when the color theme changed.

How to test

  • Download test extension and include it in the plugins folder inside theia.
  • Reload the application.
Test activeColorTheme:
  • Call the command Echo Theme via the command palette.
  • Observe a pop-up message with the exact kind of current color theme.
Test onDidChangeActiveColorTheme:
  • Change theme kind by Preferences
  • Observe a pop-up message upon the change of current theme.

Example of a pop-up message:
image

Review checklist

Reminder for reviewers

Signed-off-by: Duc Nguyen duc.a.nguyen@ericsson.com

… API

Signed-off-by: DukeNgn <duc.a.nguyen@ericsson.com>
@vince-fugnitto vince-fugnitto added CQ Required (deprecated) issues requiring a CQ (contributor questionnaire) vscode issues related to VSCode compatibility labels Nov 5, 2020
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work very well 👍 I'll add an explicit approval once the CQ I filed is approved.
I verified that:

  • the Echo Theme command successfully displays the active theme kind using the activeColorTheme API
  • the onDidChangeActiveColorTheme successfully fires when a theme is updated, and the message correctly displays.

@vince-fugnitto
Copy link
Member

The CQ has been approved 👍

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the changes once again and they work very well 👍

Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, feature is working.

@vince-fugnitto vince-fugnitto merged commit 4314838 into eclipse-theia:master Nov 10, 2020
@vince-fugnitto vince-fugnitto deleted the dn/addActiveThemeApi branch November 10, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CQ Required (deprecated) issues requiring a CQ (contributor questionnaire) vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

activeColorTheme api is not supported by THEIA
3 participants